[MRG] preassembly for conda/python #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- get_assemble_files() returns list of files needed for assembly - if buildpack.assemble_with_subset is set, only load assemble_files prior to running assembly scripts. Load the rest of the repo afterward conda opts in to this, but currently I think this works for everything *except* requirements.txt
allows assemble_from_subset when requirements.txt doesn't contain any local references
This was referenced Jul 16, 2019
minrk
force-pushed
the
conda-env-first-again-again
branch
from
e96622c
to
4f3f192
Compare
|
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: |
|
I think a |
betatim
reviewed
Jul 16, 2019
|
I bumped the local pip check up one so that it applies to conda as well (adding unittests, too) |
save preassembly of pipenv for a later patch
|
I decided to save pipenv for the preassembly for another PR, since that should be done by parsing the Pipfile toml, which is added in #748. |
betatim
reviewed
Jul 18, 2019
Co-Authored-By: Tim Head <betatim@gmail.com>
minrk
changed the title
|
Bimbambosch! Nice work. |
Closed
markmo
pushed a commit
to markmo/repo2docker
that referenced
this pull request
Jan 22, 2021
[MRG] preassembly for conda/python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-issue of #410 based on #716
-e .)pipenv always preassembles (may need local ref check like requirements.txt?)